-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify loading call #132
Conversation
test models please |
1 similar comment
test models please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the code seems like it could be cleaner, whether that's on your end or my end I don't know.
@@ -22,7 +22,7 @@ def new_qbarFun(self, c): | |||
barc = self.static["\\bar{c}"] | |||
return [f(c) for f in self.static.substitutions[barc]] | |||
|
|||
def setup(self, static, Wcent): | |||
def setup(self, static, Wcent=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Wcent even an argument?
FitCS(df, agust, [cosminus1*vgust/V]), | ||
V == v, | ||
CL == cl, | ||
Ww == Wwing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for backwards compatibility so I don't break jho and gassolar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix gassolar and jho once this is done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be tempted to make their usage of this more hacky (repeating arguments or w/e) rather than have confusing code in gplibrary...
No description provided.