Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on geotools and bump JTS to 1.16.1 #290

Merged
merged 12 commits into from
Jun 12, 2020
Merged

Remove dependency on geotools and bump JTS to 1.16.1 #290

merged 12 commits into from
Jun 12, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Jun 5, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This supersedes #103.

@evansiroky
Copy link
Contributor

The tests were failing because there was at least one spot that had incorrect ordering of lat/lon coordinates when using the x and y from the Coordinate class. I just pushed a fix to this branch that fixes that.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jun 10, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2020

Codecov Report

Merging #290 into dev will increase coverage by 0.66%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #290      +/-   ##
============================================
+ Coverage     65.35%   66.02%   +0.66%     
  Complexity      880      880              
============================================
  Files           135      134       -1     
  Lines          6749     6676      -73     
  Branches        793      792       -1     
============================================
- Hits           4411     4408       -3     
+ Misses         2038     1968      -70     
  Partials        300      300              
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/conveyal/gtfs/CropGTFS.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/Geometries.java 75.00% <ø> (ø) 4.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/PatternFinder.java 87.50% <ø> (+2.27%) 20.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/model/Pattern.java 80.00% <ø> (ø) 5.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/model/Shape.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/util/Util.java 96.42% <ø> (ø) 14.00 <0.00> (ø)
...nveyal/gtfs/validator/DuplicateStopsValidator.java 58.06% <ø> (ø) 6.00 <0.00> (ø)
...onveyal/gtfs/validator/MisplacedStopValidator.java 94.44% <ø> (ø) 5.00 <0.00> (ø)
...conveyal/gtfs/validator/ReversedTripValidator.java 7.69% <0.00%> (-1.08%) 3.00 <0.00> (ø)
src/main/java/com/conveyal/gtfs/GTFSFeed.java 67.15% <100.00%> (-0.59%) 40.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a733ce1...03d8a04. Read the comment docs.

@landonreed landonreed merged commit 74d7340 into dev Jun 12, 2020
@evansiroky
Copy link
Contributor

🎉 This PR is included in version 6.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

evansiroky added a commit to ibi-group/datatools-server that referenced this pull request Oct 1, 2020
this geotools dependency includes coordinate reference libraries and was removed in the latest gtfs-lib release in conveyal/gtfs-lib#290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants