Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty strings #293

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Handle empty strings #293

merged 5 commits into from
Oct 20, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Oct 19, 2020 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR addresses ibi-group/datatools-ui#619 and ibi-group/datatools-ui#616 by better handling empty string values passed to JdbcTableWriter for updates to GTFS entities. It also enhances tests to verify that trip_id is auto-generated for empty string literals.

@evansiroky evansiroky removed their assignment Oct 19, 2020
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see comments about setting the json field to null in another code block.

src/main/java/com/conveyal/gtfs/loader/JdbcTableWriter.java Show resolved Hide resolved
src/main/java/com/conveyal/gtfs/loader/JdbcTableWriter.java Outdated Show resolved Hide resolved
@landonreed landonreed merged commit 8f50f49 into dev Oct 20, 2020
@landonreed landonreed deleted the handle-empty-strings branch October 20, 2020 19:43
@binh-dam-ibigroup binh-dam-ibigroup mentioned this pull request Oct 22, 2020
Merged
4 tasks
@evansiroky
Copy link
Contributor

🎉 This PR is included in version 6.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@landonreed landonreed

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@landonreed @evansiroky @binh-dam-ibigroup