Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty strings #293

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Handle empty strings #293

merged 5 commits into from
Oct 20, 2020

Commits on Oct 19, 2020

  1. test(JdbcTableWriterTest): handle empty string literals in route upda… 

    …te tests

re ibi-group/datatools-ui#616
    @landonreed
    landonreed committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    a6e6fd6 View commit details
    Browse the repository at this point in the history

  2. test(JdbcTableWriterTest): verify that trip_id is not empty string af… 

    …ter creation

re ibi-group/datatools-ui#619
    @landonreed
    landonreed committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    b391cbf View commit details
    Browse the repository at this point in the history

  3. test(JdbcTableWriterTest): assert new trip_id is UUID

    @landonreed
    landonreed committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    cfe5f6d View commit details
    Browse the repository at this point in the history

  4. fix(JdbcTableWriter): handle empty string for trip_id or string field 

    fix ibi-group/datatools-ui#619; fix ibi-group/datatools-ui#616
    @landonreed
    landonreed committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    365420b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. refactor(JdbcTableWriter): address PR #293 comments

    @landonreed
    landonreed committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    cf1a247 View commit details
    Browse the repository at this point in the history