Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent update breaks due to use of --wait #5

Closed
qnm opened this issue Dec 2, 2022 · 1 comment
Closed

Recent update breaks due to use of --wait #5

qnm opened this issue Dec 2, 2022 · 1 comment

Comments

@qnm
Copy link

qnm commented Dec 2, 2022

We were using action-deploy@master and have seen the following issue:

Run convox/action-deploy@master
  with:
    rack: integration
    app: xxxxxxxx
    password: ***
    description: push xxxxxxxxxxx (#1740)
    host: console.convox.com
  env:
    CONVOX_PASSWORD: ***
    CONVOX_HOST: console.convox.com
/usr/bin/docker run --name xxxxxxxx --label 290506 --workdir /github/workspace --rm -e "CONVOX_PASSWORD" -e "CONVOX_HOST" -e "INPUT_RACK" -e "INPUT_APP" -e "INPUT_PASSWORD" -e "INPUT_DESCRIPTION" -e "INPUT_HOST" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/social/social":"/github/workspace" xxxxx
Deploying
ERROR: unknown flag: --wait

At a guess, this is caused by the command using --wait (https://github.com/convox/action-deploy/blob/master/entrypoint.sh#L12) but the updated CLI (71598e2) not providing the option.

@heronrs
Copy link
Contributor

heronrs commented Dec 2, 2022

Thanks for reporting this @qnm . I guess the workaround, for now, is to use the previous version.
We'll fix this asap

@qnm qnm closed this as completed Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants