Add exception handler #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
exception_handler
branch
5 times, most recently
from
35e4a12
to
5ce1aba
Compare
k0kubun
force-pushed
the
exception_handler
branch
from
5ce1aba
to
bd828aa
Compare
|
To keep barbeque.gem simple, I changed |
|
pluggable 👍 |
makimoto
reviewed
Sep 30, 2016
| module Barbeque | ||
| module ExceptionHandler | ||
| def self.handle_exception(e) | ||
| handler = const_get(Barbeque.config.exception_handler, false) |
There was a problem hiding this comment.
IMO, const_get takes a cost so you might like to memorize handler like @handler ||= const_get(Barbeque.config.exception_handler, false).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Raven.capture_exception.Raven.Barbeque::Workermust be rescued and given to this exception handler.Changes
Add exception handler to handle exception with
Rails.loggerorRaven.Please review 👓 @cookpad/dev-infra