Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise version #5

Closed
olup opened this issue Oct 21, 2020 · 2 comments
Closed

Promise version #5

olup opened this issue Oct 21, 2020 · 2 comments

Comments

@olup
Copy link

olup commented Oct 21, 2020

Can I suggest a promisified version of this ? I had to encapsulate it - but getting it out of the box in case no callback is provided would be a must !

@coolgk
Copy link
Owner

coolgk commented Oct 21, 2020

Hi @olup, I definitely understand the pain of having no promise by default, but this was done for a reason.

IE 11 doesn't support promise :(

In order to keep the size small, I left it to the users to decide what Promise wrapper/polyfill they choose to use instead of bundle one with this package. I hope this makes sense :)

@olup
Copy link
Author

olup commented Oct 21, 2020

Oh, I see, didn't get this ie11 requirement. I'll close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants