Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip ]Mercure integration #1

Closed
wants to merge 58 commits into from
Closed

[wip ]Mercure integration #1

wants to merge 58 commits into from

Conversation

COil
Copy link
Member

@COil COil commented Jun 1, 2023

slim and others added 30 commits May 16, 2023 15:42
This is a proof of concept. It highlights changed entitities in index
view.

Mercure : https://symfony.com/doc/current/mercure.html
This uses the mercure protocol to send a message to the clients in real
time when an entity has been updated on the server
Error using reserved words in setSearchFields (like order). There was a partial fix using escapeDqlAlias method, that should be also applied to the parentEntityName in manytoone relation joins
User gets to chose which mercure hub he wants to use with EasyAdmin by
setting 'ea.hub' parameter in his service.yml file
This PR was merged into the 4.x branch.

Discussion
----------

[chore] Fix coding style

This PR applies `php-cs-fixer` diff to address unrelated coding style errors in EasyCorp#5769 and EasyCorp#5770 without introducing any functional changes.

Commits
-------

c16dc79 Apply php-cs-fixer diff
This PR was merged into the 4.x branch.

Discussion
----------

Fix dynamic property deprecation notice

This PR will add the missing property left by PR EasyCorp#5621 to fix dynamic property deprecation notice

```txt
  26x: Creation of dynamic property EasyCorp\Bundle\EasyAdminBundle\Tests\Test\Trait\CrudTestFormAssertsTraitTest::$adminUrlGenerator is deprecated
    26x in CrudTestFormAssertsTraitTest::setUp from EasyCorp\Bundle\EasyAdminBundle\Tests\Test\Trait
```

Commits
-------

c18b59f Add missing  property
This is a proof of concept. It highlights changed entitities in index
view.

Mercure : https://symfony.com/doc/current/mercure.html
slim and others added 22 commits May 30, 2023 16:21
User gets to chose which mercure hub he wants to use with EasyAdmin by
setting 'ea.hub' parameter in his service.yml file
…errors (asispts)

This PR was merged into the 4.x branch.

Discussion
----------

Fix incorrect HTTP status code for form validation errors

This PR will fix EasyCorp#5768

**Before**

![000](https://github.com/EasyCorp/EasyAdminBundle/assets/79239132/75cc902e-1766-48f2-bfb5-00d4f0cc7036)

**After**

![001](https://github.com/EasyCorp/EasyAdminBundle/assets/79239132/f88999b8-f2f5-42dd-a121-af691c68d1e3)

Commits
-------

712959e Return HTTP 422 on form validation error
This PR was merged into the 4.x branch.

Discussion
----------

Update EntityRepository.php

Error using reserved words in setSearchFields (like order). There was a partial fix using escapeDqlAlias method, that should be also applied to the parentEntityName in ManytoOne relation joins

<!--
Thanks for your contribution! If you are proposing a new feature that is complex,
please open an issue first so we can discuss about it.

Note: all your contributions adhere implicitly to the MIT license
-->

Commits
-------

b45cd6c Update EntityRepository.php
…lth-program)

This PR was merged into the 4.x branch.

Discussion
----------

Bug: code re-applies your filters on searches

"Re-apply your filters on searches" must work with any data structure. Right now it doesn't work, if filter data is like
`"manager" => "Anna"`
it always requires an array

Commits
-------

d8ccda7 Update layout.html.twig
@COil COil added WIP Work In Progress enhancement New feature or request labels Jun 1, 2023
@COil COil assigned slim Jun 1, 2023
@COil COil marked this pull request as draft June 1, 2023 12:19
@COil COil changed the title Mercure integration [wip ]Mercure integration Jun 1, 2023
@COil
Copy link
Member Author

COil commented Jun 1, 2023

Closing as unwanted commit have been included.

@COil COil closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP Work In Progress
Projects
None yet
6 participants