Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer '*.hpp' over '*.h' (opionated) #16

Closed
daixtrose opened this issue May 4, 2020 · 1 comment
Closed

Prefer '*.hpp' over '*.h' (opionated) #16

daixtrose opened this issue May 4, 2020 · 1 comment

Comments

@daixtrose
Copy link

TL;DR:

Please revert 98b9c17

Discussion

IIRC there were really good reasons to have C++ header files end with .hpp rather than .h. Some had to do with IDE discriminating between C and C++. I believe the Boost Community went through this discussion some decades ago, but I can't find the original discussion quickly. Please find other opinions below

Pro

Contra

@bgeller
Copy link
Member

bgeller commented May 4, 2020

As explained in a comment on the commit, this was done to conform with the rest of the CopperSpice code base. We understand developers have different preferences, however consistency is extremely important. Looking at your pro and con list sort of shows that is no formal agreement.

@bgeller bgeller closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants