Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing GitHub Actions #19

Closed
shubhanshu02 opened this issue Dec 13, 2021 · 2 comments
Closed

Failing GitHub Actions #19

shubhanshu02 opened this issue Dec 13, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@shubhanshu02
Copy link
Member

I can see the last three workflow runs failed in the "Build Project" step with an error related to threads. This step runs the generate command as written in the package.json.

Expected Behavior

Since there's nothing wrong as far as I can see in the code for this repo, things are expected to work fine.

Current Behavior

Builds are failing.

Possible Reason

The GitHub actions seem to run with Node with versions 14 and 16 from the following lines in the workflow.

strategy:
matrix:
os: [ubuntu-latest]
node: [14, 16]

The errors in the actions seem to be related to the node-fibers package in the package.json. As per the package repo, the package is obsolete on newer versions of Node.js due to a breaking change in the V8 engine and has reached its EOL.

Read below:

Update [April 13th, 2021] -- Fibers is not compatible with nodejs v16.0.0 or later. Unfortunately, v8 commit dacc2fee0f is a breaking change and workarounds are non-trivial.

IMO, the builds are failing when the node v16 is being used.

Possible Solution

There are two possible solutions to this:

  1. Remove the fibers package from package.json if it isn't being used anywhere.
  2. Use a version of node strictly lower than 16.
@shubhanshu02 shubhanshu02 added the bug Something isn't working label Dec 13, 2021
@king-11
Copy link
Member

king-11 commented Dec 14, 2021

Thanks for flagging at @shubhanshu02 this was fixed in the recent commit that I made fibers was needed for a 2x compilation of SASS maybe we can look at it later not necessary now.

@king-11
Copy link
Member

king-11 commented Dec 14, 2021

Closed by #8a032be

@king-11 king-11 closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants