fix definition of InnerProductSpace #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
reviewed
Nov 30, 2016
| @@ -88,7 +89,9 @@ Class InnerProductSpace (K V : Type) | |||
| ; in_srorder :>> SemiRingOrder Kle | |||
| ; in_comm :> Commutative inprod | |||
| ; in_linear_l : ∀ a u v, ⟨a·u,v⟩ = a*⟨u,v⟩ | |||
| ; in_nonneg :> ∀ v, PropHolds (0 ≤ ⟨v,v⟩) (* TODO Le to strong? *) | |||
| ; in_pos_def1 :> ∀ v, PropHolds (0 ≤ ⟨v,v⟩) (* TODO Le to strong? *) | |||
There was a problem hiding this comment.
What do you think about preserving the original name for in_nonneg? The names in_pos_def1 and in_pos_def2 are not descriptive.
|
@urkud What do you think about these names? |
urkud
reviewed
Dec 6, 2016
| ; in_comm :> Commutative inprod | ||
| ; in_linear_l : ∀ a u v, ⟨a·u,v⟩ = a*⟨u,v⟩ | ||
| ; in_nonneg :> ∀ v, PropHolds (0 ≤ ⟨v,v⟩) (* TODO Le to strong? *) | ||
| ; in_mon_unit_zero :> ∀ v, 0 = ⟨v,v⟩ <-> v = mon_unit |
There was a problem hiding this comment.
Slightly offtopic: is there any good example of a module over a ring with something but "+" as the group operation? If not, why do we use a generic AbGroup instead of Add V and AbGroup (Aop := (+))?
|
ping @spitters |
|
@siddharthist Sorry for the delay. |
|
@spitters Thanks for the review & merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
I'm very open to feedback on the names especially!