Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix definition of InnerProductSpace #17

Merged
merged 2 commits into from
Feb 2, 2017
Merged

fix definition of InnerProductSpace #17

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e697ee
fix definition of InnerProductSpace
langston-barrett Nov 22, 2016
054cce9
better names for vectorspace axioms
langston-barrett Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions interfaces/vectorspace.v
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Require Import
Require Import
MathClasses.interfaces.abstract_algebra MathClasses.interfaces.orders.

(** Scalar multiplication function class *)
Expand All @@ -14,6 +14,7 @@ Notation "(· x )" := (λ y, y · x) (only parsing) : mc_scope.
Class Inproduct K V := inprod : V → V → K.
Instance: Params (@inprod) 3.

Notation "(⟨⟩)" := (inprod) (only parsing) : mc_scope.
Notation "⟨ u , v ⟩" := (inprod u v) (at level 51) : mc_scope.
Notation "⟨ u , ⟩" := (λ v, ⟨u,v⟩) (at level 50, only parsing) : mc_scope.
Notation "⟨ , v ⟩" := (λ u, ⟨u,v⟩) (at level 50, only parsing) : mc_scope.
Expand Down Expand Up @@ -88,7 +89,9 @@ Class InnerProductSpace (K V : Type)
; in_srorder :>> SemiRingOrder Kle
; in_comm :> Commutative inprod
; in_linear_l : ∀ a u v, ⟨a·u,v⟩ = a*⟨u,v⟩
; in_nonneg :> ∀ v, PropHolds (0 ≤ ⟨v,v⟩) (* TODO Le to strong? *)
; in_pos_def1 :> ∀ v, PropHolds (0 ≤ ⟨v,v⟩) (* TODO Le to strong? *)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about preserving the original name for in_nonneg? The names in_pos_def1 and in_pos_def2 are not descriptive.

; in_pos_def2 :> ∀ v, 0 = ⟨v,v⟩ <-> v = mon_unit
; inprod_proper :> Proper ((=) ==> (=) ==> (=)) (⟨⟩)
}.

(* TODO complex conjugate?
Expand Down