Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no longer needed lemmas (as of mathcomp-1.11) #37

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Conversation

chdoc
Copy link
Member

@chdoc chdoc commented Nov 14, 2021

No description provided.

@chdoc
Copy link
Member Author

chdoc commented Nov 14, 2021

@palmskog , this drops mathcomp-1.9 and mathcomp-1.10`, but I think three versions of mathcomp are enough. If we make a release with theory changes, maybe it's a good idea to include this.

@palmskog
Copy link
Member

@chdoc dropping 1.9 and 1.10 is perfectly fine by me, now that we have a release that is likely to work for a while on 1.13. Should I modify meta.yml and the CI configuration in the PR branch?

@chdoc
Copy link
Member Author

chdoc commented Nov 15, 2021

@chdoc dropping 1.9 and 1.10 is perfectly fine by me, now that we have a release that is likely to work for a while on 1.13. Should I modify meta.yml and the CI configuration in the PR branch?

Yes, please do.

@palmskog palmskog mentioned this pull request Dec 29, 2021
- [all/ex]1s -> [forall/exists]_cons (as in mathcomp-1.13)
- remove global hints for mem_head and ltn_ord
@chdoc chdoc marked this pull request as ready for review January 5, 2022 16:10
@chdoc
Copy link
Member Author

chdoc commented Jan 5, 2022

As far as I am concerned, this is ready to be merged.

@palmskog
Copy link
Member

palmskog commented Jan 5, 2022

Hmm, I think we could also bump to 8.15 compatibility, and add at least Nix CI for 8.15 (the MC 8.15 Docker images are not available yet). Or should we do 8.15 in a separate PR?

@chdoc
Copy link
Member Author

chdoc commented Jan 5, 2022

I think that should be a separate PR. Also, I don't expect any changes to the .v files for 8.15, given that master checks just fine.

@palmskog palmskog merged commit ba48ad6 into master Jan 6, 2022
@palmskog palmskog deleted the trim-misc branch January 6, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants