Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we make coq-ltac2 a dummy package in 8.11 instead of requiring Coq < 8.11? #1422

Open
cpitclaudel opened this issue May 19, 2020 · 11 comments

Comments

@cpitclaudel
Copy link

Description of the problem

I'm trying to support 8.9 through 8.11 in the same project. I use Ltac2, so I have a dependency on the coq-ltac2 package. But currently that package requires Coq < 8.11.

Could the coq-ltac2 be marked as compatible with 8.11 and made to install a dummy package there? Or is there a simpler solution that I overlooked?

cc @ppedrot

@SkySkimmer
Copy link
Contributor

SkySkimmer commented May 19, 2020 via email

@JasonGross
Copy link
Member

According to https://opam.ocaml.org/doc/Manual.html, the correct syntax is probably "coq-ltac2" | "coq" { >= "8.11~" } (the ~ allows capturing also the beta versions, I believe)

@cpitclaudel
Copy link
Author

Thanks, I should have looked there. I only looked at https://dune.readthedocs.io/en/stable/dune-files.html#package, and AFAICT dune doesn't support that. Am I missing something?

@JasonGross
Copy link
Member

Indeed, it looks like this feature might be missing from dune. @ejgallego?

@ejgallego
Copy link
Member

I don't recall the status of that, at least on master you should be able to do:

(package
 (name cohttp)
 (synopsis "An OCaml library for HTTP clients and servers")
 (description "A longer description")
 (depends
  (alcotest :with-test)
  (dune (> 1.5))
  (foo (or :dev (> 1.5) (< 2.0)))
  (uri (>= 1.9.0))
  (uri (< 2.0.0))
  (fieldslib (> v0.12))
  (fieldslib (< v0.13))))

@cpitclaudel
Copy link
Author

This is an OR between versions, but we need an OR between packages.

@ejgallego
Copy link
Member

This is an OR between versions, but we need an OR between packages.

If that's not yet implemented I'd suggest you file a feature request and hopefully will solved soon. I can check what's the status of this but not today sorry.

@cpitclaudel
Copy link
Author

ocaml/dune#3497

@ejgallego
Copy link
Member

Thanks a lot for the report @cpitclaudel , regarding the opam issue, I suggest to re-submit at https://github.com/coq/opam-coq-archive/issues as it is an issue of the repos.

@Zimmi48
Copy link
Member

Zimmi48 commented Sep 16, 2020

Isn't it the whole issue? It is easy to transfer issues between repos of the same organization @ejgallego.

@Zimmi48 Zimmi48 reopened this Sep 16, 2020
@Zimmi48 Zimmi48 transferred this issue from coq/coq Sep 16, 2020
@ejgallego
Copy link
Member

It is easy to transfer issues between repos of the same organization @ejgallego.

Oh sorry I was not aware of that, thanks for taking care of the transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants