Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elpi: check if the -j 1 opam patch can be removed #314

Closed
MSoegtropIMC opened this issue Dec 1, 2022 · 5 comments
Closed

Elpi: check if the -j 1 opam patch can be removed #314

MSoegtropIMC opened this issue Dec 1, 2022 · 5 comments

Comments

@MSoegtropIMC
Copy link
Collaborator

See

[make "build" "DUNE_OPTS=--display verbose -p %{name}% -j 1"]
.

@gares
Copy link
Member

gares commented Dec 2, 2022

I was not aware of the problem. What is it?

@MSoegtropIMC
Copy link
Collaborator Author

We discussed it a while back - elpi does (or did) not compile reliably in CI without -j 1. It failed in roughly 1 out of 4 runs. With -j 1 it does run reliably. I took it as action item to check if this was gone by some magic but I couldn't find time to do this (one should do 20 CI runs to be sure) so I left it in. I will remove it after the release, so that we can have proper CI statistics until 8.17.

@MSoegtropIMC
Copy link
Collaborator Author

It is not a big deal since elpi also compiles with -j 1 reasonably fast and it is not on the critical path, even with -j 12 or so.

@gares
Copy link
Member

gares commented Dec 2, 2022

OK

@MSoegtropIMC
Copy link
Collaborator Author

Triage note: latest elpi runs fine in CI with -j jobs. As noted above it is not worthwhile to investigate this for older versions since it anyway builds fast (and in parallel with other packages) -> closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants