-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coq-Elpi (& hierarchy-builder) #5
Comments
IMHO the platform should be viewed as an object that is fully independent of the current Windows installer (even if it should eventually, hopefully as soon as 8.13, supersede it). So I would say 1.5.0 is a good pick for the first platform release. The platform will still officially be in an experimental state for the first release anyway, so the constraints are somehow more relaxed. |
@gares : Can you please recommend a tag for Coq-elpi and hierarchy builder for the Coq platform 8.11.2 (I plan to release one as well) and Coq platform 8.12.0? A plain build of coq-elpi from opam does not seem to work even on 8.11.2 - it starts building and successfully installs quite a few prerequisites put the build of coq-elpi itself fails for 8.11.2. |
Are you building on a memory constrained machine? The version for 8.11 (1.4.x iirc, I'm on vac) runs a test that needs 2+GB. For 8.12 we don't have yet a HB release, only a coq-elpi one (1.5.1). I should be able to be more precise next week. |
No, I have tested this with 32 and 128 GB. Maybe the opam files or not up to date. |
Both 1.4.1 and 1.5.0 should work on 8.11. There is no HB tag using 1.5.0 yet. Would you mind posting the error? I don't have a laptop to try it out myself. |
We do have a tag now, 0.10. we may still lack an open package. cc @CohenCyril |
Thanks - I will do some test runs over the weekend. Missing opam packages are no issue - the Coq platform comes with its own opam patch repo. |
We now have an opam package as well, and as per coq/coq#12391 Coq 8.12.1 is likely to get these versions as well. |
Very well - I will test it this week. The platform alpha3 release was still mostly technical and I didn't put much effort into package completeness. Now I will focus on this. |
@gares : I tried simple "opam install coq-elpi" on the 8.11.2 platform and I get this error:
My opam package version list is:
|
On the Coq platform 8.12 it is the same. Maybe the OCaml version I use (4.07.1)? Can you please try the coq platform 8.11 and 8.12 alpha3 scripts - they should run on pretty much any platform with a posix shell now. The scripts create new opam switches for the coq platform with these names:
so they shouldn't change anything in your existing setup. |
Another test didn't work either:
The detailed error messages are as above. I tested this on macOS - in case you think this is a Mac specific sandboxing issue (not unheard of), I can also try it on Linux and Windows - the errors look to unspecific to me to judge this. |
P.S.: I also tried to disable sandboxing on Mac - this doesn't work either. |
OK, now some good news: on Linux (Ubuntu 18.04) and Windows it does work both for 8.11.2 and 8.12.0. Any idea what the Mac issue could be? There is not really an error message - it just says "exit 1". Maybe we can have a remote debug session on my Mac. |
@gares : I debugged this and found that elpi is using "sha1sum". This is not available on mac by default, but can be installed using Macports and homebrew (package name is in both cases
How shall we fix this? The options I see are
|
I tested that Of cause we can still go with the opam conf option if you want to avoid new tags. |
Sorry I was one vac and I had no time to read this. Your fix is great! |
@gares : I have one more issue: CoqElpi does not work in CoqIDE 8.11.2 - I guess you know that since someone fixed it in 8.12.0. My plan is to also publish a Coq platform for Coq 8.11.2 (at the same time as for 8.12.0). Any suggestions what I should do with Elpi:
In case you are not aware: the following piece of code works in VSCoq 8.11.2 but not in CoqIDE 8.11.2:
|
Hum, is it the parsing of I think that at some point I tried to fix CoqIDE (it pre-chops the text looking for |
FTR, elpi 1.11.4 which includes your sha1sum fix is released |
@gares: I added it to the v8.12 branch - you can try it there. Please note that this branch does a full parallel build which requires a bit more than 13 GB of RAM, so you should have at least 16 GB physical (I will add a sequential build option later). For 8.11 I will add a note displayed after install if CoqIDE and coq-elpi are installed, that CoqIDE does not work with Coq-elpi and that it does work in 8.12. |
This is fixed meanwhile. coq-elpi is included in 8.12.2 and 2021.02.0. I will delay creating of Platforms for older versions of Coq (something which is useful for fighting package bit rot). If I include coq-elpi in such older releases we can see then. |
I'd like Coq-Elpi and hierarchy-builder to be in. They are already in the Coq installer for windows.
I have a question. Context: I'd like to release, this week probably, a version of Coq-Elpi that takes advantage of a few new features of Coq 8.12, version 1.5.0. Should we pick it? Can we pick it for the platform?
The one shipped with the installer is almost identical to the released version 1.4.1 which works on Coq 8.11. I think this would be ideal for the platform, since it has almost no incompatibility with the previous version. But there is no platform for 8.11, and no Coq-Elpi in the windows installer for 8.11 either. So I'm considering the idea, better to break compatibility now than later.
But, I don't know if, on Windows, the platform has to agree with the installer or not. If it has to agree then we have to stay with 1.4.1, but if has not to agree then I'll invest energy this week to make a 1.5.0 release (and adjust hierarchy-builder to it).
The text was updated successfully, but these errors were encountered: