Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coq 8.13 and coq-native #60

Open
gares opened this issue Jan 8, 2021 · 7 comments
Open

Coq 8.13 and coq-native #60

gares opened this issue Jan 8, 2021 · 7 comments
Assignees
Labels
kind: enhancement New feature or request

Comments

@gares
Copy link
Member

gares commented Jan 8, 2021

Since Coq 8.13 CEP 48 is implemented.

In short, when the (empty) package coq-native is installed, coq is configured to pre compile stuff for native_compute.
We should be asking the question in the platform scripts (and provide a -coq-native=[y/n] option).

@MSoegtropIMC MSoegtropIMC self-assigned this Jan 11, 2021
@MSoegtropIMC
Copy link
Collaborator

OK, I will do this. On which platforms is Coq-native expected to work? I think on Windows it should also work if one uses the cygwin/opam based from source variant which includes opam.

@gares
Copy link
Member Author

gares commented Jan 11, 2021

All of them. It seems it is slow on osx (the loader is slow), so I guess it should contain a generic warning that compilation time for .v files may increase (but you get fast native_compute).

@gares
Copy link
Member Author

gares commented Jan 11, 2021

To be tested in the installers, which don't ship ocamlc. It should work with at most a warning.

@MSoegtropIMC MSoegtropIMC added the kind: enhancement New feature or request label Sep 25, 2021
@MSoegtropIMC MSoegtropIMC added this to the 2022.03 milestone Mar 21, 2022
@MSoegtropIMC
Copy link
Collaborator

@gares : I am reviewing old issues ...

I have two questions / thoughts on this:

  • users already complain that the questions asked by the script are lengthy, so I wonder if we should just provide a command line option - it is more a pro feature. or alternatively we could have an option / question to ask "pro" questions
  • I wonder if the parallel install method of Coq Platform works - it does request all packages at once. Would I need to install the coq-native package upfront sequentially?

@MSoegtropIMC MSoegtropIMC modified the milestones: 2022.03, 2022.03.1 Mar 22, 2022
@gares
Copy link
Member Author

gares commented Mar 23, 2022

I think you would need to install it upfront, even before installing coq.

Brainstoming: what about telling power users needing the feature to edit the package selection file and add coq-native upfront?

@Zimmi48
Copy link
Member

Zimmi48 commented Jun 23, 2022

What about having a question asking users if they want the pro or basic mode and showing very few questions to users of the latter?

@MSoegtropIMC MSoegtropIMC modified the milestones: 2022.03.1, 2022.09 Sep 13, 2022
@MSoegtropIMC MSoegtropIMC modified the milestones: 2022.09, 2023.03 Sep 29, 2022
@MSoegtropIMC
Copy link
Collaborator

Triage note: planned for the 8.20 release.

@MSoegtropIMC MSoegtropIMC modified the milestones: 2023.03, 2024.08-Coq8.20 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants