Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create password field doesn't support keyboard cut or copy shortcuts #874

Closed
trucy opened this issue Sep 26, 2022 · 2 comments · Fixed by #907
Closed

Create password field doesn't support keyboard cut or copy shortcuts #874

trucy opened this issue Sep 26, 2022 · 2 comments · Fixed by #907

Comments

@trucy
Copy link

trucy commented Sep 26, 2022

When creating a new password, if a user enters something in the "Create Password" field, tries to copy that with Command+C and paste using Command+V into the "Confirm Password" field, it will take whatever was last on the user's keyboard instead.

Since this input doesn't currently have a show/hide password action, it's hard to know what the error is if your password lengths look the same and the user doesn't realize the copy/paste keyboard shortcut isn't working as expected.

Is it difficult to allow copy and cut functions on this input or was this done intentionally?

I'd suggest in the future allowing a user to show/hide the password field so they can verify what was input before continuing.

copy paste password

In this video, I first copy and paste from a password manager (20 chars) which works as expected, followed by an example where I type in 8 characters and try to copy and paste that to the 2nd field. Since copy doesn't work, it takes the content from my clipboard (the 20 char password) and pastes that instead of the 8 char password I expected.

@tomlinton
Copy link
Contributor

Copy/cut is disabled in HTML password forms by default for security reasons. You can work around that, or we can add a show password option to each form field and make that copyable.

@trucy
Copy link
Author

trucy commented Sep 26, 2022

@tomlinton thanks for the context. If it's not too much trouble, can we add the following icon to those inputs for now? The various states would look like this:

Screen Shot 2022-09-26 at 5 49 13 PM

  • Base or Neutral/400 for the actionable icon
  • Eye and Eye Off material design icons in the same spot as other right-sided icons in inputs

Thank you and lmk if you have any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants