[CORL-1281] Prevent viewNewEdges from being garbage collected (#3121)

* fix: prevent viewNewEdges from being garbage collected * fix: add local data to optimistic responses Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com>
coralproject · Aug 20, 2020 · e701628 · e701628
1 parent 7cbc47b
commit e701628
Show file tree

Hide file tree

Showing 8 changed files with 1,241 additions and 673 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -335,7 +335,7 @@
     "react-final-form-arrays": "^3.1.1",
     "react-helmet": "^5.2.1",
     "react-popper": "^1.3.7",
-    "react-relay": "^9.0.0",
+    "react-relay": "^10.0.1",
     "react-relay-network-modern": "^4.6.1",
     "react-responsive": "^8.0.3",
     "react-test-renderer": "^16.13.1",
@@ -344,10 +344,10 @@
     "recharts": "^1.8.5",
     "recompose": "^0.30.0",
     "regenerator-runtime": "^0.13.5",
-    "relay-compiler": "^9.0.0",
+    "relay-compiler": "^10.0.1",
     "relay-compiler-language-typescript": "^12.0.3",
     "relay-local-schema": "^0.8.0",
-    "relay-runtime": "^9.0.0",
+    "relay-runtime": "^10.0.1",
     "resize-observer-polyfill": "^1.5.1",
     "sane": "^4.1.0",
     "shallow-equals": "^1.0.0",

diff --git a/src/core/client/admin/routes/Moderate/Queue/QueueRoute.tsx b/src/core/client/admin/routes/Moderate/Queue/QueueRoute.tsx
@@ -199,6 +199,10 @@ const createQueueRoute = (
               @connection(key: "Queue_comments") {
               viewNewEdges {
                 cursor
+                node {
+                  id
+                  ...ModerateCardContainer_comment
+                }
               }
               edges {
                 node {

diff --git a/src/core/client/stream/tabs/Comments/Comment/ReplyCommentForm/CreateCommentReplyMutation.ts b/src/core/client/stream/tabs/Comments/Comment/ReplyCommentForm/CreateCommentReplyMutation.ts
@@ -209,6 +209,8 @@ async function commit(
                 id,
                 createdAt: currentDate,
                 status: "NONE",
+                pending: false,
+                lastViewerAction: null,
                 author: {
                   id: viewer.id,
                   username: viewer.username,
@@ -258,6 +260,7 @@ async function commit(
                 },
                 replies: {
                   edges: [],
+                  viewNewEdges: [],
                   pageInfo: { endCursor: null, hasNextPage: false },
                 },
                 deleted: false,

diff --git a/src/core/client/stream/tabs/Comments/ReplyList/ReplyListContainer.tsx b/src/core/client/stream/tabs/Comments/ReplyList/ReplyListContainer.tsx
@@ -286,6 +286,14 @@ const ReplyListContainer3 = createReplyListContainer(
           @connection(key: "ReplyList_replies") {
           viewNewEdges {
             cursor
+            node {
+              id
+              replyCount
+              enteredLive
+              ...CommentContainer_comment
+              ...IgnoredTombstoneOrHideContainer_comment
+              ...LocalReplyListContainer_comment
+            }
           }
           edges {
             node {
@@ -366,6 +374,13 @@ const ReplyListContainer2 = createReplyListContainer(
           @connection(key: "ReplyList_replies") {
           viewNewEdges {
             cursor
+            node {
+              id
+              enteredLive
+              ...CommentContainer_comment
+              ...IgnoredTombstoneOrHideContainer_comment
+              ...ReplyListContainer3_comment
+            }
           }
           edges {
             node {
@@ -445,6 +460,13 @@ const ReplyListContainer1 = createReplyListContainer(
           @connection(key: "ReplyList_replies") {
           viewNewEdges {
             cursor
+            node {
+              id
+              enteredLive
+              ...CommentContainer_comment
+              ...IgnoredTombstoneOrHideContainer_comment
+              ...ReplyListContainer2_comment
+            }
           }
           edges {
             node {

diff --git a/src/core/client/stream/tabs/Comments/Stream/AllCommentsTab/AllCommentsTabContainer.tsx b/src/core/client/stream/tabs/Comments/Stream/AllCommentsTab/AllCommentsTabContainer.tsx
@@ -297,6 +297,10 @@ const enhanced = withPaginationContainer<
           @connection(key: "Stream_comments") {
           viewNewEdges {
             cursor
+            node {
+              enteredLive
+              ...AllCommentsTabContainer_comment @relay(mask: false)
+            }
           }
           edges {
             node {

diff --git a/src/core/client/stream/tabs/Comments/Stream/PostCommentForm/CreateCommentMutation.ts b/src/core/client/stream/tabs/Comments/Stream/PostCommentForm/CreateCommentMutation.ts
@@ -196,6 +196,8 @@ async function commit(
                 id,
                 createdAt: currentDate,
                 status: "NONE",
+                pending: false,
+                lastViewerAction: null,
                 author: {
                   id: viewer.id,
                   username: viewer.username,
@@ -231,6 +233,7 @@ async function commit(
                 },
                 replies: {
                   edges: [],
+                  viewNewEdges: [],
                   pageInfo: { endCursor: null, hasNextPage: false },
                 },
                 story: {

diff --git a/...ient/stream/tabs/Comments/Stream/UnansweredCommentsTab/UnansweredCommentsTabContainer.tsx b/...ient/stream/tabs/Comments/Stream/UnansweredCommentsTab/UnansweredCommentsTabContainer.tsx
@@ -250,6 +250,10 @@ const enhanced = withPaginationContainer<
           @connection(key: "UnansweredStream_comments") {
           viewNewEdges {
             cursor
+            node {
+              enteredLive
+              ...UnansweredCommentsTabContainer_comment @relay(mask: false)
+            }
           }
           edges {
             node {