Stream Rebranding #2926
Merged
Stream Rebranding #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-funk
force-pushed
the
feature/stream-rebranding
branch
5 times, most recently
from
c0b2162
to
28bb11b
Compare
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
7a1db5d
to
7a373ac
Compare
nick-funk
force-pushed
the
feature/stream-rebranding
branch
2 times, most recently
from
38bdddf
to
b2ec4d6
Compare
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
b2ec4d6
to
34a431c
Compare
nick-funk
force-pushed
the
feature/stream-rebranding
branch
3 times, most recently
from
96e0190
to
29f2de9
Compare
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
29f2de9
to
9b967cc
Compare
tessalt
requested changes
Jun 8, 2020
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
0786b19
to
a198b54
Compare
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
7b78188
to
f9e8f91
Compare
tessalt
approved these changes
Jun 12, 2020
* [ADR] Use Relay over Apollo (#2881) * chore: ADR on Relay and Apollo * chore: typo * chore: add neg cons * chore: add another pos * chore: remove neg, because apollo needed an introspection query as a build step too.. * chore: fix number * chore: deco * chore: typo * chore: clarification Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * chore: bump 6.0.0 (#2891) * fix: added more checks to migration (#2894) * Update stream username to new branding variables CORL-901 * Update badges/tags to use new v2 controls CORL-901 * Update timestamps to use new branding stream side CORL-901 * Update stream edit action to new branding CORL-901 * Update comment html body to new branding CORL-901 * Update comment action buttons to new branding CORL-901 * Update responsive styles for action buttons CORL-901 * Set comment link colors to new branding blue CORL-901 * Add children prop on ButtonsBar to align with tests CORL-901 * Make Reported button text bolded and vivid red CORL-901 * Make reaction buttons stream blue when reacted CORL-901 * Make user badges bold text CORL-901 * Set margins on comment action buttons CORL-901 * Set aria-labels on reaction buttons Ensures that we always have a usable aria even when the reaction button is just an icon. CORL-901 * Set aria-label's on Reply and Share button's CORL-901 * Update tests to match stream branding changes CORL-901 * Update color of "Read More of this conversation" CORL-901 Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com>
* [ADR] Use Relay over Apollo (#2881) * chore: ADR on Relay and Apollo * chore: typo * chore: add neg cons * chore: add another pos * chore: remove neg, because apollo needed an introspection query as a build step too.. * chore: fix number * chore: deco * chore: typo * chore: clarification Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * chore: bump 6.0.0 (#2891) * fix: added more checks to migration (#2894) * Update stream username to new branding variables CORL-901 * Update badges/tags to use new v2 controls CORL-901 * Update timestamps to use new branding stream side CORL-901 * Update stream edit action to new branding CORL-901 * Update comment html body to new branding CORL-901 * Update comment action buttons to new branding CORL-901 * Update responsive styles for action buttons CORL-901 * Set comment link colors to new branding blue CORL-901 * Add children prop on ButtonsBar to align with tests CORL-901 * Make Reported button text bolded and vivid red CORL-901 * Make reaction buttons stream blue when reacted CORL-901 * Make user badges bold text CORL-901 * Set margins on comment action buttons CORL-901 * Set aria-labels on reaction buttons Ensures that we always have a usable aria even when the reaction button is just an icon. CORL-901 * Set aria-label's on Reply and Share button's CORL-901 * Update tests to match stream branding changes CORL-901 * Update color of "Read More of this conversation" CORL-901 * Update caret container to new branding CORL-942 * Update moderation menu buttons to new branding CORL-942 * Update in-stream ban popover to new branding CORL-942 * Update reject tombstone to new branding CORL-942 Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com>
* [ADR] Use Relay over Apollo (#2881) * chore: ADR on Relay and Apollo * chore: typo * chore: add neg cons * chore: add another pos * chore: remove neg, because apollo needed an introspection query as a build step too.. * chore: fix number * chore: deco * chore: typo * chore: clarification Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * chore: bump 6.0.0 (#2891) * fix: added more checks to migration (#2894) * Update stream username to new branding variables CORL-901 * Update badges/tags to use new v2 controls CORL-901 * Update timestamps to use new branding stream side CORL-901 * Update stream edit action to new branding CORL-901 * Update comment html body to new branding CORL-901 * Update comment action buttons to new branding CORL-901 * Update responsive styles for action buttons CORL-901 * Set comment link colors to new branding blue CORL-901 * Add children prop on ButtonsBar to align with tests CORL-901 * Make Reported button text bolded and vivid red CORL-901 * Make reaction buttons stream blue when reacted CORL-901 * Make user badges bold text CORL-901 * Set margins on comment action buttons CORL-901 * Set aria-labels on reaction buttons Ensures that we always have a usable aria even when the reaction button is just an icon. CORL-901 * Set aria-label's on Reply and Share button's CORL-901 * Update tests to match stream branding changes CORL-901 * Update color of "Read More of this conversation" CORL-901 * Update caret container to new branding CORL-942 * Update moderation menu buttons to new branding CORL-942 * Update in-stream ban popover to new branding CORL-942 * Update reject tombstone to new branding CORL-942 * Update replyTo and rte to new branding CORL-939 Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com>
CORL-1009
CORL-968
CORL-1041
CORL-940
marginSize -> paddingSize textSize -> fontSize
CORL-904
Allows us to direct call gulp clean easily.
CORL-1025
CORL-1025
CORL-1025
CORL-1025
CORL-1025
Somehow this slipped through the cracks, fixed it up now
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
Horizontal rule wasn't conditionally showing when we toggled ability to let users download comments on and off.
Can now pass in a localization id to assign aria-label/title to the tab.
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
f9e8f91
to
afb06b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main branch for all rebranding of the client stream.