[CORL 1010] Collapse comment threads #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-funk
force-pushed
the
feature/stream-rebranding
branch
from
29f2de9
to
9b967cc
Compare
nick-funk
approved these changes
Jun 5, 2020
nick-funk
force-pushed
the
feature/CORL-1010
branch
from
cccf39c
to
26b6ede
Compare
nick-funk
pushed a commit
that referenced
this pull request
Jun 8, 2020
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
nick-funk
pushed a commit
that referenced
this pull request
Jun 9, 2020
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
nick-funk
pushed a commit
that referenced
this pull request
Jun 12, 2020
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
nick-funk
added a commit
that referenced
this pull request
Jun 12, 2020
* [CORL-901] Rebrand comment actions and body (#2889) * [ADR] Use Relay over Apollo (#2881) * chore: ADR on Relay and Apollo * chore: typo * chore: add neg cons * chore: add another pos * chore: remove neg, because apollo needed an introspection query as a build step too.. * chore: fix number * chore: deco * chore: typo * chore: clarification Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * chore: bump 6.0.0 (#2891) * fix: added more checks to migration (#2894) * Update stream username to new branding variables CORL-901 * Update badges/tags to use new v2 controls CORL-901 * Update timestamps to use new branding stream side CORL-901 * Update stream edit action to new branding CORL-901 * Update comment html body to new branding CORL-901 * Update comment action buttons to new branding CORL-901 * Update responsive styles for action buttons CORL-901 * Set comment link colors to new branding blue CORL-901 * Add children prop on ButtonsBar to align with tests CORL-901 * Make Reported button text bolded and vivid red CORL-901 * Make reaction buttons stream blue when reacted CORL-901 * Make user badges bold text CORL-901 * Set margins on comment action buttons CORL-901 * Set aria-labels on reaction buttons Ensures that we always have a usable aria even when the reaction button is just an icon. CORL-901 * Set aria-label's on Reply and Share button's CORL-901 * Update tests to match stream branding changes CORL-901 * Update color of "Read More of this conversation" CORL-901 Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * [CORL-942] In-Stream Mod rebranding (#2902) * [ADR] Use Relay over Apollo (#2881) * chore: ADR on Relay and Apollo * chore: typo * chore: add neg cons * chore: add another pos * chore: remove neg, because apollo needed an introspection query as a build step too.. * chore: fix number * chore: deco * chore: typo * chore: clarification Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * chore: bump 6.0.0 (#2891) * fix: added more checks to migration (#2894) * Update stream username to new branding variables CORL-901 * Update badges/tags to use new v2 controls CORL-901 * Update timestamps to use new branding stream side CORL-901 * Update stream edit action to new branding CORL-901 * Update comment html body to new branding CORL-901 * Update comment action buttons to new branding CORL-901 * Update responsive styles for action buttons CORL-901 * Set comment link colors to new branding blue CORL-901 * Add children prop on ButtonsBar to align with tests CORL-901 * Make Reported button text bolded and vivid red CORL-901 * Make reaction buttons stream blue when reacted CORL-901 * Make user badges bold text CORL-901 * Set margins on comment action buttons CORL-901 * Set aria-labels on reaction buttons Ensures that we always have a usable aria even when the reaction button is just an icon. CORL-901 * Set aria-label's on Reply and Share button's CORL-901 * Update tests to match stream branding changes CORL-901 * Update color of "Read More of this conversation" CORL-901 * Update caret container to new branding CORL-942 * Update moderation menu buttons to new branding CORL-942 * Update in-stream ban popover to new branding CORL-942 * Update reject tombstone to new branding CORL-942 Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * [CORL-939] Rebrand RTE and reply (#2904) * [ADR] Use Relay over Apollo (#2881) * chore: ADR on Relay and Apollo * chore: typo * chore: add neg cons * chore: add another pos * chore: remove neg, because apollo needed an introspection query as a build step too.. * chore: fix number * chore: deco * chore: typo * chore: clarification Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * chore: bump 6.0.0 (#2891) * fix: added more checks to migration (#2894) * Update stream username to new branding variables CORL-901 * Update badges/tags to use new v2 controls CORL-901 * Update timestamps to use new branding stream side CORL-901 * Update stream edit action to new branding CORL-901 * Update comment html body to new branding CORL-901 * Update comment action buttons to new branding CORL-901 * Update responsive styles for action buttons CORL-901 * Set comment link colors to new branding blue CORL-901 * Add children prop on ButtonsBar to align with tests CORL-901 * Make Reported button text bolded and vivid red CORL-901 * Make reaction buttons stream blue when reacted CORL-901 * Make user badges bold text CORL-901 * Set margins on comment action buttons CORL-901 * Set aria-labels on reaction buttons Ensures that we always have a usable aria even when the reaction button is just an icon. CORL-901 * Set aria-label's on Reply and Share button's CORL-901 * Update tests to match stream branding changes CORL-901 * Update color of "Read More of this conversation" CORL-901 * Update caret container to new branding CORL-942 * Update moderation menu buttons to new branding CORL-942 * Update in-stream ban popover to new branding CORL-942 * Update reject tombstone to new branding CORL-942 * Update replyTo and rte to new branding CORL-939 Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> * Update message box to new branding CORL-981 * Update user profile comment history to new branding CORL-983 * Update stream tabs to new branding CORL-982 * Update my profile tab bar to new branding CORL-902 * Update download comments to new branding CORL-902 * The Lord of the Buttons: Return of the Buttons * Update the notification settings area to new branding CORL-984 * Update the ignored users area to new branding CORL-984 * Update change username to new branding CORL-984 * Fixing snaps after rebase * Use label instead of div for InputLabel's Root element is now a label so that axe will stop complaining that it can't find the 'for' id on the label elements. CORL-984 * More spacing tweaks for change username CORL-903 * Update change email address to new branding CORL-984 * Update change password to new branding CORL-984 * Flesh out colour styles for v3 buttons CORL-984 * Preliminarily update delete account to new branding CORL-984 * Ensure client CSS style compatibility CORL-984 * Update delete flow to new branding CORL-984 * Add client classes to the delete account modal CORL-984 * Further tweaks to the delete account modal Modal callouts updated to new branding. Deletion request callout updated to new branding. Fixing up tests that somehow were passing before? Fixing some margins and spacing around deletion section. * Move the account deletion callout to top Puts it at the top of the my profile tab so that it's clearly visible you are deleting your account. CORL-998 * Add first-class icon and title support to callouts CORL-969 * Bold checkbox text when checked CORL-984 * Finalize v3 buttons to match spec This should be the last major change to v3 buttons as the spec seems to have solidified. CORL-969 * Add in new stream red to colours Use it for the negative v3 callouts CORL-969 * Touch up some spacing on delete account CORL-984 * Create tombstone component Use it for ignored and deleted account tombstones instead of the old callout. CORL-969 * Use new tombstones in comment stream CORL-969 * Update banned callout to new branding CORL-969 * Set callout body text to regular font weight CORL-969 * Update suspended callout to new branding CORL-969 * Update closed stream callouts to new branding CORL-969 * Update in-moderation callouts to new branding CORL-969 * Update stream validation message to v3 CORL-969 * Improve ignored commenter management Show "you are no longer ignoring" a commenter when you choose to no longer ignore them. CORL-457 * Prettier cleanup after rebase off master Somehow this was missed, probably needed to kill and reload VSCode before I committed the rebase. * Switch previous callouts to use icon and title CORL-969 * Update configure checkboxes to new branding CORL-903 * Update Config > Q&A to new branding CORL-903 * Update Config > Open/Close Stream to new branding CORL-903 * Add validation message to config stream checkboxes CORL-903 * Remove double list handling for Pref>Ignored CORL-969 * Show experimental tag beside Q&A config CORL-1051 * Move live update setting to its own section CORL-903 * Remove moderation link from config area CORL-903 * De-capitalize all the labels in configure CORL-903 * Update message box config to new branding Also moves it to new location in config. CORL-903 * Re-brand the sign in/out field on the stream CORL-1042 * Update tests for add message flow CORl-903 * Rebrand Sign In/Up modals CORL-999 * Re-brand SSO sign in/up modals CORL-999 * Re-brand stream sorting controls CORL-1043 * Create new stream focused colorFromMeta variant * Rebrand go to moderation buttons CORL-799 * Rebrand stream moderation drop-down CORL-799 * Rebrand the report comment flow Expands the report comment dialogs under the comment instead of as a popover. Also adds in the new branding styles. CORL-941 * Rebrand the main stream tab bar CORL-799 * Add new abusive reporting options CORL-1009 * Rebrand featured comments CORL-968 * Rebrand the community guidelines CORL-1041 * Rebrand the share button CORL-940 * Update style names on buttons marginSize -> paddingSize textSize -> fontSize * Rebrand single conversation view CORL-904 * Make indented comments grey coloured CORL-904 * Make indented comment borders thinner CORL-904 * Tweak colours/margins on single conversation view CORL-904 * Add show comment on single conversation tombstones CORL-412 * Rebrand single conversation view title CORL-904 * Add clean target to package.json Allows us to direct call gulp clean easily. * Rebrand client side not found page CORL-1025 * Rebrand password reset flow CORL-1025 * Rebrand unsubscribe from notifications flow CORL-1025 * Rebrand email confirmation flow CORL-1025 * Rebrand download comments flow CORL-1025 * Fix up account tests after rebrand CORL-1025 * Add COMMENT_REPORTED_ABUSIVE to moderate card fragment * Rebrand user ignore flow Somehow this slipped through the cracks, fixed it up now * [CORL 1010] Collapse comment threads (#2976) * toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots * Fix tests and snaps after rebase * Make main stream tabs visible on mobile (iPhone 5) * Remove double horizontal rule under My Comments Horizontal rule wasn't conditionally showing when we toggled ability to let users download comments on and off. * Add aria labelling to main stream tabs Can now pass in a localization id to assign aria-label/title to the tab. * Add localization to account not found * Update snapshots Co-authored-by: Vinh <vinh@vinh.tech> Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com> Co-authored-by: Tessa Thornton <tessathornton@gmail.com>
tessalt
added a commit
that referenced
this pull request
Jul 6, 2020
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
tessalt
added a commit
that referenced
this pull request
Jul 10, 2020
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
tessalt
added a commit
that referenced
this pull request
Jul 14, 2020
* toggle open and closed comment + replies * show username and date for collapsed comment * toggle comments and replies open and closed * keep collapsed state of comments in reply list * style collapsed comment toggle * add css class overrides * style answered comments when collapsed * adjust spacing on collapse button: * add hover styles * add aria labels and update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a button beside each comment to collapse the comment and its reply thread
What changes to the GraphQL/Database Schema does this PR introduce?
none
How do I test this PR?
Click the "-" button beside a comment on a stream with comments and replies