Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORL-1029] Better HTML Support #2956

Merged
merged 16 commits into from Jun 8, 2020
Merged

[CORL-1029] Better HTML Support #2956

merged 16 commits into from Jun 8, 2020

Conversation

cvle
Copy link
Member

@cvle cvle commented May 7, 2020 •
edited

What does this PR do?

  • Move to @coralproject/rte v1.0.0
  • Harmonize HTML sanitization on server and client
  • Harmonize HTML character length counting on server and client
  • Allow pasting of HTML content
  • Integrate bulleted list, strikethrough (deactivated), and spoiler (deactivated) feature
  • Improve suspect/banned word highlighting in moderation (faster, more accurate, better display)
  • More accurate perspective score by using a better text representation of html content
  • More accurate detection of suspect and banned words

How do I test this PR?

  • Write comments
  • Copy and paste HTML content

@cvle cvle changed the title [CORL-1029] Better RTE HTML Support [CORL-1029] Better HTML Support May 7, 2020
@cvle cvle requested a review from wyattjoh May 7, 2020 14:16
@cvle cvle marked this pull request as ready for review May 7, 2020 17:47
wyattjoh
wyattjoh reviewed May 7, 2020
View reviewed changes
src/core/client/admin/components/Comment/CommentContent.tsx Outdated Show resolved Hide resolved
src/core/client/admin/components/Comment/CommentContent.tsx Outdated Show resolved Hide resolved
src/core/client/stream/tabs/Comments/Comment/ReplyCommentForm/ReplyCommentFormContainer.tsx Outdated Show resolved Hide resolved
src/core/client/stream/tabs/Comments/RTE/RTE.tsx Outdated Show resolved Hide resolved
src/core/client/stream/tabs/Comments/Stream/PostCommentForm/PostCommentFormContainer.tsx Outdated Show resolved Hide resolved
src/core/common/helpers/createPurify.ts Outdated Show resolved Hide resolved
src/core/common/helpers/createPurify.ts Outdated Show resolved Hide resolved
src/core/server/services/comments/pipeline/phases/repeatPost.ts Outdated Show resolved Hide resolved
@kgardnr kgardnr added this to the v6.3.0 milestone May 8, 2020
@cvle cvle mentioned this pull request May 21, 2020
Merged
cvle added 3 commits June 8, 2020 13:02
@cvle @nick-funk
Merge branch 'master' into feat/CORL-1029
24316a7
@cvle @nick-funk
fix: merge issues
f68f616
@cvle @nick-funk
[CORL-1056] Configurable RTE (#2967)
62fb603 
* fix: merge issues

* feat: Configure RTE

* test: add tests

* chore: just a comment

* chore: remove unused translations
@nick-funk nick-funk merged commit 72e1b24 into master Jun 8, 2020
@nick-funk nick-funk deleted the feat/CORL-1029 branch June 8, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyattjoh wyattjoh wyattjoh left review comments

@nick-funk nick-funk nick-funk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cvle @wyattjoh @nick-funk @kgardnr