Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1056] Configurable RTE #2967

Merged
merged 5 commits into from Jun 8, 2020
Merged

[CORL-1056] Configurable RTE #2967

merged 5 commits into from Jun 8, 2020

Conversation

cvle
Copy link
Member

@cvle cvle commented May 21, 2020

What does this PR do?

  • Implement RTE configuration
  • Prevent empty comments from being accepted by the server (e.g. only empty lines)

How do I test this PR?

  • Access config in Admin -> Config -> General -> Rich-text comments
  • See result on stream and post comments

Requires #2956

@cvle cvle requested a review from wyattjoh May 21, 2020 19:44
@cvle cvle changed the title [CORL-1056] Configuring RTE options [CORL-1056] Configurable RTE May 21, 2020
@cvle cvle marked this pull request as ready for review May 21, 2020 19:45
@cvle cvle added this to the v6.3.0 milestone May 21, 2020
@nick-funk nick-funk merged commit 3ccb402 into feat/CORL-1029 Jun 8, 2020
@nick-funk nick-funk deleted the feat/CORL-1056 branch June 8, 2020 18:55
nick-funk pushed a commit that referenced this pull request Jun 8, 2020
* fix: merge issues

* feat: Configure RTE

* test: add tests

* chore: just a comment

* chore: remove unused translations
nick-funk pushed a commit that referenced this pull request Jun 8, 2020
* feat: Improve html handling, integrate new @coralproject/rte

* chore: refactor and add comments

* chore: remove obsolete line

* chore: rename `inputId` to `inputID`

* chore: upgrade @coralproject/rte

* fix: update snapshots

* chore: apply review suggestions

* fix: snapshot / tests

* fix: merge issues

* [CORL-1056] Configurable RTE (#2967)

* fix: merge issues

* feat: Configure RTE

* test: add tests

* chore: just a comment

* chore: remove unused translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants