Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1209] remove hook causing crash from conversation modal replies #3057

Merged
merged 1 commit into from Jul 31, 2020

Conversation

tessalt
Copy link
Contributor

@tessalt tessalt commented Jul 31, 2020

What does this PR do?

useMemo hook was being used after a conditional statement in a function component, which is a weird thing that you can't do in react and was causing the crash logged in 1209. Removed the hook and the crash is fixed.

What changes to the GraphQL/Database Schema does this PR introduce?

none

@tessalt tessalt requested review from cvle and wyattjoh July 31, 2020 14:18
@wyattjoh wyattjoh added this to the v6.3.1 milestone Jul 31, 2020
@wyattjoh wyattjoh merged commit 40ad2ed into master Jul 31, 2020
@wyattjoh wyattjoh deleted the bugfix/CORL-1209 branch July 31, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants