add react hooks eslint plugin #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-funk
approved these changes
Aug 3, 2020
wyattjoh
requested changes
Aug 3, 2020
tessalt
force-pushed
the
feature/add-hooks-eslint-rule
branch
from
ba0c7bf
to
06024e1
Compare
wyattjoh
approved these changes
Aug 4, 2020
tessalt
force-pushed
the
feature/add-hooks-eslint-rule
branch
from
d71b30b
to
dbe29fc
Compare
wyattjoh
added
the
🚀 merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds an eslint plugin to enforce hooks rules, some of which are weird and cause unexpected runtime errors like the one fixed in #3057. Plugin does catch this issue:
What changes to the GraphQL/Database Schema does this PR introduce?
none