Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1239] Swap setTimeout for setLongTimeout #3071

Merged
merged 5 commits into from Aug 4, 2020
Merged

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Aug 3, 2020

What does this PR do?

When dealing with user controlled input, we should use setLongTimeout to avoid int overflow issues.

What changes to the GraphQL/Database Schema does this PR introduce?

None.

How do I test this PR?

Set the story auto-close timeout to 30 days, notice how stories younger than that don't show as closed sometimes!

@wyattjoh wyattjoh added the bug label Aug 3, 2020
@wyattjoh wyattjoh added this to the v6.3.2 milestone Aug 3, 2020
@wyattjoh wyattjoh requested a review from tessalt August 3, 2020 23:25
@wyattjoh wyattjoh added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 4, 2020
@kodiakhq kodiakhq bot merged commit 9d02391 into master Aug 4, 2020
@kodiakhq kodiakhq bot deleted the bugfix/CORL-1239 branch August 4, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants