Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setTimeout Fixes #3082

Merged
merged 3 commits into from Aug 6, 2020
Merged

setTimeout Fixes #3082

merged 3 commits into from Aug 6, 2020

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Aug 5, 2020

What does this PR do?

Fixes some issues around setTimeout where the timeout wasn't managed correctly or was typed wrong. 

What changes to the GraphQL/Database Schema does this PR introduce?

None.

@wyattjoh wyattjoh added the bug label Aug 5, 2020
@wyattjoh wyattjoh added this to the v6.3.2 milestone Aug 5, 2020
@wyattjoh wyattjoh requested a review from cvle August 5, 2020 23:41
cvle
cvle approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@cvle cvle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@cvle cvle added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 6, 2020
@kodiakhq kodiakhq bot merged commit b029a01 into master Aug 6, 2020
@kodiakhq kodiakhq bot deleted the set-timeout-fixes branch August 6, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvle cvle cvle approved these changes

Assignees
No one assigned
Labels
bug 🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Milestone
v6.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wyattjoh @cvle