Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1291] Logging Improvements #3103

Merged
merged 3 commits into from Aug 14, 2020
Merged

[CORL-1291] Logging Improvements #3103

merged 3 commits into from Aug 14, 2020

Conversation

wyattjoh
Copy link
Collaborator

What does this PR do?

Whenever settings are updated, log the fields being updated as well as the user performing the action.

What changes to the GraphQL/Database Schema does this PR introduce?

None.

How do I test this PR?

Update settings, see the new log entry: settings update audit.

@wyattjoh wyattjoh added this to the v6.3.3 milestone Aug 12, 2020
@wyattjoh wyattjoh requested a review from tessalt August 12, 2020 23:09
Copy link
Contributor

@tessalt tessalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the way our settings forms work, this is logging every key from whatever page you were on:
image

(In this case I only edited the media rating setting)

@wyattjoh
Copy link
Collaborator Author

That’s true. This is a stop gap until we’re able to replace our settings update mutations with more discrete mutations that would let us apply auditing on the mutation/schema level.

@wyattjoh wyattjoh added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 14, 2020
@kodiakhq kodiakhq bot merged commit d001fcd into master Aug 14, 2020
@kodiakhq kodiakhq bot deleted the bugfix/CORL-1291 branch August 14, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants