Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1282] Hide user media preferences if all media types are disabled #3107

Merged
merged 3 commits into from Aug 18, 2020

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

If the admin's turn off all three of the media options (Giphy, Twitter, and YouTube) then we don't show the user the option to automatically unfurl all media.

What changes to the GraphQL/Database Schema does this PR introduce?

None

How do I test this PR?

  • Turn off all 3 media options under Admin > Config
  • Go to your stream > My Profile > Preferences
  • See that the unfurl media option is missing
  • Turn one of the 3 options on under Admin > Config
  • Refresh stream > My Profile > Preferences
  • See that the unfurl media options is present

@nick-funk nick-funk requested a review from tessalt August 14, 2020 15:28
@kgardnr kgardnr added this to the v6.3.3 milestone Aug 15, 2020
@kgardnr kgardnr added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 18, 2020
@kodiakhq kodiakhq bot merged commit ca9456a into master Aug 18, 2020
@kodiakhq kodiakhq bot deleted the feature/CORL-1282-hide-media-pref branch August 18, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants