[CORL-1293] Sentry Error Integration #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
force-pushed
the
feature/CORL-1293
branch
from
502a281
to
7e056cb
Compare
tessalt
reviewed
Aug 20, 2020
| // Parse the config from the element text, it should always be a valid JSON | ||
| // string if the element is available. We should allow the error to bubble if | ||
| // we are unable to parse it. | ||
| const config: StaticConfig = JSON.parse(element.innerText); |
There was a problem hiding this comment.
this is a bit scary, is there a reason we can't pass these values around like other config values?
There was a problem hiding this comment.
We want the error reporter setup as early as possible. Otherwise we won't capture network related errors. This is the same mechanism that we pass updates to the public path (See src/core/build/publicPath.js).
tessalt
reviewed
Aug 20, 2020
| return { | ||
| id: user.id, | ||
| username: user.username || undefined, | ||
| email: user.email || undefined, |
There was a problem hiding this comment.
do we need to send email to the error reporter? I'd feel more comfortable if it was just id
There was a problem hiding this comment.
The email was to aid in responding to users that experience errors, but we can certainly remove it!
tessalt
approved these changes
Aug 20, 2020
cvle
reviewed
Aug 20, 2020
kgardnr
added
the
🚀 merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
apollo-server-expresswith vanilla implementation.What changes to the GraphQL/Database Schema does this PR introduce?
None.
How do I test this PR?
TBD