Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-1292] Set better aria labels on the comment action buttons #3126

Merged
merged 3 commits into from Aug 20, 2020

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

Adds more descriptive aria labels to the comment action buttons like React, Share, and Reply.

What changes to the GraphQL/Database Schema does this PR introduce?

None

How do I test this PR?

  • Go to comment stream
  • Right click on an action button within a comment
  • Inspect element
  • See that the button element has an aria label similar to Reply to comment by <username>

@kgardnr kgardnr added this to the v6.3.3 milestone Aug 20, 2020
@kgardnr kgardnr self-requested a review August 20, 2020 22:48
@kgardnr kgardnr added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 20, 2020
@kodiakhq kodiakhq bot merged commit aa3273f into master Aug 20, 2020
@kodiakhq kodiakhq bot deleted the feature/CORL-1292-action-arias branch August 20, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants