Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORL-1327] allow configuration of admin and moderator comment tags #3156

Merged
merged 9 commits into from Sep 2, 2020
Merged

[CORL-1327] allow configuration of admin and moderator comment tags #3156

merged 9 commits into from Sep 2, 2020

Conversation

tessalt
Copy link
Contributor

@tessalt tessalt commented Sep 1, 2020

What does this PR do?

Adds new more specific tags to comments based on user role: instead of tagging all comments from staff, moderator, and admin users as "staff", they are now tagged with their respective roles. Also allows customization of display labels for these tags, defaulting all three to "staff".

What changes to the GraphQL/Database Schema does this PR introduce?

  • Adds ADMIN and MODERATOR tags to Tag enum
  • adds staff.adminLabel and staff.moderatorLabel to tenant settings

How do I test this PR?

  • under general configuration, change the labels for moderator or admin roles to something other than "staff"
  • make a comment as a moderator or admin
  • observe the comment being tagged with the appropriate role

@kgardnr kgardnr added this to the v6.3.5 milestone Sep 1, 2020
@kgardnr kgardnr added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Sep 2, 2020
@cvle cvle removed the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Sep 2, 2020
wyattjoh
wyattjoh requested changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@wyattjoh wyattjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more small tweaks and it's perfect!

src/core/server/graph/resolvers/StaffConfig.ts Outdated Show resolved Hide resolved
src/core/server/graph/resolvers/Settings.ts Outdated Show resolved Hide resolved
@wyattjoh wyattjoh added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Sep 2, 2020
@kodiakhq kodiakhq bot merged commit 1c3d631 into master Sep 2, 2020
@kodiakhq kodiakhq bot deleted the feature/CORL-1327-badges branch September 2, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyattjoh wyattjoh wyattjoh approved these changes

Assignees
No one assigned
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Milestone
v6.3.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tessalt @wyattjoh @kgardnr @cvle