CORDA-1999 Changed isRelevant to relevancyStatus. #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecoll
previously approved these changes
Sep 18, 2018
| @@ -113,8 +113,9 @@ class NodeVaultService( | |||
| // For EVERY state to be committed to the vault, this checks whether it is spendable by the recording | |||
| // node. The behaviour is as follows: | |||
| // | |||
| // 1) All vault updates marked as RELEVANT will, of, course all have isRelevant = true. | |||
| // 2) For ALL_VISIBLE updates, those which are not relevant according to the relevancy rules will have isRelevant = false. | |||
| // 1) All vault updates marked as RELEVANT will, of, course all have relevancyStatus = true. | |||
There was a problem hiding this comment.
Probably want to rephrase this now that relevancyStatus is clearly no longer a boolean (true, false).
There was a problem hiding this comment.
Ah.. in the DB, the relevancy flag is actually a boolean but this wording isn't very clear. I'll change it.
There was a problem hiding this comment.
Actually it's an INT in the db - the default type used for Enum type mappings ;-)
There was a problem hiding this comment.
I think the comment still needs updating (or removing).
There was a problem hiding this comment.
Ah whoops forgot... Just pushed up the changes now.
|
Over to you @josecoll ! |
josecoll
changed the title
roastario
pushed a commit
to roastario/corda
that referenced
this pull request
Nov 8, 2018
* Changed isRelevant to relevancyStatus. * Fix cash selection from breaking. * Fixed non-backwards compatible API change. * Updated schema migration changelog. * Updated comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.