Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORDA-2851] - Fix the way serialization whitelist is calculated for CordappImpl #4743

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

dimosr
Copy link
Contributor

@dimosr dimosr commented Feb 12, 2019

Changes

This change includes the actual whitelisted classes in the set of all classes of a cordapp.

Testing

  • Added a unit test that was previously failing, because the name of the CordappImpl was added, instead of the actual set of whitelisted classes.

@dimosr dimosr self-assigned this Feb 12, 2019
@mikehearn mikehearn changed the title [CORDA-2546] - Remove default whitelist from loaded cordapps [CORDA-2546] - Remove default serialization whitelist from loaded cordapps Feb 14, 2019
@dimosr dimosr force-pushed the remove-default-whitelist-from-cordapps branch from 83e68b8 to b012b40 Compare April 10, 2019 16:06
@dimosr
Copy link
Contributor Author

dimosr commented Apr 10, 2019

rebased and kept only the changes for the whitelist.
The duplicate warnings has already been fixed by Dom in a separate PR:
#4848

@dimosr dimosr changed the title [CORDA-2546] - Remove default serialization whitelist from loaded cordapps [CORDA-2546] - Fix the way serialization whitelist is calculated for CordappImpl Apr 10, 2019
@dimosr dimosr changed the title [CORDA-2546] - Fix the way serialization whitelist is calculated for CordappImpl [CORDA-2851] - Fix the way serialization whitelist is calculated for CordappImpl Apr 11, 2019
@shamsasari shamsasari merged commit a38891f into master Apr 11, 2019
@shamsasari shamsasari deleted the remove-default-whitelist-from-cordapps branch April 11, 2019 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants