-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx: fix PageCount update in allocate #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 85.56% 85.57% +<.01%
==========================================
Files 9 9
Lines 1857 1858 +1
==========================================
+ Hits 1589 1590 +1
+ Misses 159 158 -1
- Partials 109 110 +1
Continue to review full report at Codecov.
|
@zrss can you add a test for this fix? thanks. |
i add an accessible method for |
Why not creating another unit test file rather than exposing |
I added a new unit test file, but not sure whether the file name is appropriate. And there is a bolt_test package for test files, why not put them in the same package as bolt (such as freelist_test.go) ... just curious about that |
Defer to @xiang90 |
lgtm |
tx: PageCount add up the count that we try to allocate