Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kola argument processing logic for platform specific options #3509

Open
travier opened this issue Jun 13, 2023 · 4 comments · May be fixed by #3752
Open

Improve kola argument processing logic for platform specific options #3509

travier opened this issue Jun 13, 2023 · 4 comments · May be fixed by #3752
Labels
good first issue Good for newcomers good-first-issue good issue for someone new

Comments

@travier
Copy link
Member

travier commented Jun 13, 2023 •
edited

Feature Request

If a platform specific option is passed to kola, it should default to that platform. For example if --aws-ami but the platform is not set, kola should default to the aws platform.

Example from (now removed):

coreos-assembler/mantle/cmd/kola/options.go

Line 180 in 0a09bd7

// TODO: Could also auto-synchronize if e.g. --aws-ami is passed

@travier travier mentioned this issue Jun 13, 2023
Merged
@travier travier added good first issue Good for newcomers good-first-issue good issue for someone new labels Jun 13, 2023
@itsCheithanya
Copy link

Hi @travier I would love to contribute!

@travier
Copy link
Member Author

travier commented Mar 11, 2024

Great! Feel free to give it a try and ask for help on Matrix.

@itsCheithanya
Copy link

Sorry @travier I'm new to this project what is Matrix, a channel like slack?

@travier
Copy link
Member Author

travier commented Mar 11, 2024

See https://github.com/coreos/fedora-coreos-tracker#communication-channels-for-fedora-coreos

@itsCheithanya itsCheithanya linked a pull request Mar 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers good-first-issue good issue for someone new
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve kola argument processing logic for platform specific options itsCheithanya/coreos-assembler
2 participants
@travier @itsCheithanya