Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild: set sysroot.bootprefix=true for aarch64 too #3774

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dustymabe
Copy link
Member

We were blocked by coreos/fedora-coreos-tracker#1647 but the 6.9 kernel series doesn't appear to have the same problem. The 6.8 kernel does have the problem but our kernel filenames in stable releases of Fedora (i.e. not rawhide) won't be long enough to trigger the bug so we should be able to safely remove this since rawhide has moved on to 6.9 rc kernels.

This should be the final piece to close out
coreos/fedora-coreos-tracker#1667

We were blocked by coreos/fedora-coreos-tracker#1647
but the 6.9 kernel series doesn't appear to have the same problem. The 6.8
kernel does have the problem but our kernel filenames in stable releases
of Fedora (i.e. not `rawhide`) won't be long enough to trigger the bug
so we should be able to safely remove this since `rawhide` has moved on
to 6.9 rc kernels.

This should be the final piece to close out
coreos/fedora-coreos-tracker#1667
Copy link

openshift-ci bot commented Apr 8, 2024

@dustymabe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos 23e4d1a link true /test rhcos

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Member

travier commented Apr 9, 2024

RHCOS CI fix in openshift/os#1478

Copy link

@lukewarmtemp lukewarmtemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ravanelli ravanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dustymabe
Copy link
Member Author

some complications on the fix in openshift/os#1478

I'm just going to merge this since it's unrelated.

@dustymabe dustymabe merged commit 167d67e into coreos:main Apr 10, 2024
4 of 5 checks passed
@dustymabe dustymabe deleted the dusty-osbuild-aarch64 branch April 10, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants