Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: ci: Gate secure boot tests on centos-stream-release #1478

Conversation

travier
Copy link
Member

@travier travier commented Apr 9, 2024

centos-stream-release now replaces centos-release. Update the package name until CentOS Stream 9 gets the new shim release and finally passes Secure Boot tests.

centos-stream-release now replaces centos-release. Update the package
name until CentOS Stream 9 gets the new shim release and finally passes
Secure Boot tests.
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe
Copy link
Member

kola-basic/firmware-uefi-secure is failing in this PR too.. are the settings update in this PR not applied when CI runs for it?

@travier
Copy link
Member Author

travier commented Apr 9, 2024

OK, I'll take another look at this tomorrow

@mike-nguyen
Copy link
Member

mike-nguyen commented Apr 9, 2024

We use centos-release to skip some of the secureboot tests. We will need to change them to centos-stream-release here and here Whoops I thought this PR was the one to switch over to centos-stream-release

@mike-nguyen
Copy link
Member

mike-nguyen commented Apr 9, 2024

In the raw build-log.txt I found

parse error: Invalid numeric literal at line 1, column 5
failed to execute cmd-kola: signal: broken pipe

Caused by cosa kola list --json which will return the command itself cosa kola list --json followed by the json output inside a coreos-assembler container.

[coreos-assembler]$ cosa kola list --json | head
kola -p qemu list --json --output-dir tmp/kola
[
	{
		"Name": "basic",
		"Platforms": [
			"aws",
			"azure",
			"do",
			"esx",
			"gcp",

versus just kola list --json which just returns the JSON.

[coreos-assembler]$ kola list --json | head
[
	{
		"Name": "basic",
		"Platforms": [
			"aws",
			"azure",
			"do",
			"esx",
			"gcp",
			"openstack",

It doesn't look like it wasn't possible to get into the conditional that adds --denylist-test *.uefi-secure

@jlebon
Copy link
Member

jlebon commented Apr 10, 2024

Should be fixed by coreos/coreos-assembler#3775.

…kage

Otherwise, we'll just always be querying the default one, which might
not be stream-based.
The latter was replaced by the former, which now Provides
`centos-release`.

This also fixes the fact that `ci/prow-entrypoint.sh` queries these
manifests and checks for `centos-stream-release` in the list of
packages. The querying happens directly on the flattened manifest,
without any depsolving, so the fact that `centos-release` is provided by
`centos-stream-release` is not relevant at all.

It would have also worked to keep `centos-release` here and keep
querying `centos-release` in the script, but it seems cleaner anyway
to be canonical and list the actual package name rather than one of its
virtual Provides.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@jlebon
Copy link
Member

jlebon commented Apr 10, 2024

Should be fixed by coreos/coreos-assembler#3775.

Actually no. That's one issue, but there were two other issues here. I've pushed up some commits inline to fix those.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@travier
Copy link
Member Author

travier commented Apr 10, 2024

Thanks Jonathan.
/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@travier: you cannot LGTM your own PR.

In response to this:

Thanks Jonathan.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member Author

travier commented Apr 10, 2024

Fixes: #1458
We really need to land coreos/coreos-assembler#3652

@jbtrystram
Copy link
Contributor

/retitle NO-JIRA: ci: Gate secure boot tests on centos-stream-release

@openshift-ci openshift-ci bot changed the title ci: Gate secure boot tests on centos-stream-release NO-JIRA: ci: Gate secure boot tests on centos-stream-release Apr 10, 2024
@openshift-ci-robot
Copy link

@travier: This pull request explicitly references no jira issue.

In response to this:

centos-stream-release now replaces centos-release. Update the package name until CentOS Stream 9 gets the new shim release and finally passes Secure Boot tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024
@jbtrystram
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jbtrystram, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,jbtrystram,jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 94146f6 into openshift:master Apr 10, 2024
7 checks passed
@travier travier deleted the main-ci-fix-centos-release-pkg-name branch April 10, 2024 13:09
@travier
Copy link
Member Author

travier commented Apr 10, 2024

Next is coreos/coreos-assembler#3775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants