-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: ci: Gate secure boot tests on centos-stream-release #1478
NO-JIRA: ci: Gate secure boot tests on centos-stream-release #1478
Conversation
centos-stream-release now replaces centos-release. Update the package name until CentOS Stream 9 gets the new shim release and finally passes Secure Boot tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
OK, I'll take another look at this tomorrow |
In the raw build-log.txt I found
Caused by
versus just
It doesn't look like it wasn't possible to get into the conditional that adds |
Should be fixed by coreos/coreos-assembler#3775. |
…kage Otherwise, we'll just always be querying the default one, which might not be stream-based.
The latter was replaced by the former, which now Provides `centos-release`. This also fixes the fact that `ci/prow-entrypoint.sh` queries these manifests and checks for `centos-stream-release` in the list of packages. The querying happens directly on the flattened manifest, without any depsolving, so the fact that `centos-release` is provided by `centos-stream-release` is not relevant at all. It would have also worked to keep `centos-release` here and keep querying `centos-release` in the script, but it seems cleaner anyway to be canonical and list the actual package name rather than one of its virtual Provides.
Actually no. That's one issue, but there were two other issues here. I've pushed up some commits inline to fix those. |
@travier: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks Jonathan. |
@travier: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: #1458 |
/retitle NO-JIRA: ci: Gate secure boot tests on centos-stream-release |
@travier: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jbtrystram, jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Next is coreos/coreos-assembler#3775 |
centos-stream-release now replaces centos-release. Update the package name until CentOS Stream 9 gets the new shim release and finally passes Secure Boot tests.