auth, e2e: the root role should be granted access to every key #6356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix CI. Some of the tests are failing. The change looks good. |
|
@xiang90 fixed the CI failure (it was caused by the semantics of the root role), PTAL. |
| @@ -666,6 +666,10 @@ func (as *authStore) isOpPermitted(userName string, revision uint64, key, rangeE | |||
| return ErrPermissionDenied | |||
| } | |||
|
|
|||
| if hasRootRole(user) { | |||
There was a problem hiding this comment.
add a comment here: root role should have permission on all ranges.
|
LGTM |
This commit changes the semantics of the root role. The role should be able to access to every key. Partially fixes etcd-io#6355
|
@gyuho Have we backport this yet? |
|
@xiang90 It's not backported yet. Should we include this in the next patch release? |
|
@gyuho yes. we should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the semantics of the root role. The role should be
able to access to every key.
Partially fixes #6355
/cc @glycerine @soyking @xiang90