Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: initialize gRPC server metrics with zero values #8878

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

brancz
Copy link
Contributor

@brancz brancz commented Nov 15, 2017

This initializes the gRPC metrics to their respective zero-values. This is useful for discovering metrics, as well as being able to differentiate whether metrics are missing due to the target missing or currently just no request having generated the metrics yet.

@xiang90 @gyuho

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Confirmed that now all gRPC metrics show up in /metrics endpoint.

Thanks!

@xiang90
Copy link
Contributor

xiang90 commented Nov 15, 2017

lgtm

@xiang90
Copy link
Contributor

xiang90 commented Nov 15, 2017

@gyuho do you know why test-cov is failing?

@gyuho
Copy link
Contributor

gyuho commented Nov 15, 2017

@xiang90

Too many goroutines running after all test(s).
1 instances of:
github.com/coreos/etcd/etcdserver/api/v3rpc.(*serverWatchStream).recvLoop(...)
	github.com/coreos/etcd/etcdserver/api/v3rpc/_obj/watch.go:284 +0x1db
github.com/coreos/etcd/etcdserver/api/v3rpc.(*watchServer).Watch.func2(...)
	github.com/coreos/etcd/etcdserver/api/v3rpc/_obj/watch.go:129 +0x35
created by github.com/coreos/etcd/etcdserver/api/v3rpc.(*watchServer).Watch
	github.com/coreos/etcd/etcdserver/api/v3rpc/_obj/watch.go:127 +0x2f9
exit status 1
FAIL	github.com/coreos/etcd/clientv3/integration	220.750s

Will create an issue.

@gyuho
Copy link
Contributor

gyuho commented Nov 15, 2017

Created a separate issue #8883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants