Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boot_device sugar #162

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Add boot_device sugar #162

merged 3 commits into from
Dec 4, 2020

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Nov 24, 2020

Add sugar for mirroring the root disk (all partitions) and/or encrypting the root partition. Design document in coreos/enhancements#3.

Example FCC:

variant: fcos
version: 1.3.0-experimental
boot_device:
  # Specifies a disk layout template.  Supported values are aarch64,
  # ppc64le, x86_64 (default).
  layout: x86_64
  mirror:
    # If specified, mirror every default partition.  Two or more devices
    # are required.
    devices:
      - /dev/vda
      - /dev/vdb
  luks:
    # If tang and/or tpm2 is specified, encrypt the root partition.
    tang:
      - url: https://example.com/
        thumbprint: x
    tpm2: true
    threshold: 2

@arithx
Copy link
Contributor

arithx commented Nov 24, 2020

The current state of the code LGTM

Retarget FCOS spec 1.3.0 to Ignition spec 3.2.0; we're going to add some
additional sugar.  We'll target 3.3.0-experimental again when FCOS spec
1.4.0-experimental opens up.
@bgilbert bgilbert changed the title WIP: add boot_device sugar add boot_device sugar Dec 2, 2020
@bgilbert bgilbert changed the title add boot_device sugar Add boot_device sugar Dec 2, 2020
@bgilbert bgilbert marked this pull request as ready for review December 2, 2020 23:26
@bgilbert
Copy link
Contributor Author

bgilbert commented Dec 2, 2020

Ready for review!

@bgilbert bgilbert requested a review from jlebon December 2, 2020 23:27
docs/configuration-v1_3-exp.md Outdated Show resolved Hide resolved
config/fcos/v1_3_exp/translate.go Outdated Show resolved Hide resolved
config/fcos/v1_3_exp/translate.go Show resolved Hide resolved
config/fcos/v1_3_exp/translate.go Outdated Show resolved Hide resolved
config/fcos/v1_3_exp/translate.go Show resolved Hide resolved
docs/configuration-v1_3-exp.md Show resolved Hide resolved
config/fcos/v1_3_exp/translate_test.go Show resolved Hide resolved
config/fcos/v1_3_exp/translate_test.go Show resolved Hide resolved
Add sugar for mirroring the root disk (all partitions) and/or encrypting
the root partition.

Example FCC:

  variant: fcos
  version: 1.3.0-experimental
  boot_device:
    # Specifies a disk layout template.  Supported values are aarch64,
    # ppc64le, x86_64 (default).
    layout: x86_64
    mirror:
      # If specified, mirror every default partition.  Two or more devices
      # are required.
      devices:
        - /dev/vda
        - /dev/vdb
    luks:
      # If tang and/or tpm2 is specified, encrypt the root partition.
      tang:
        - url: https://example.com/
          thumbprint: x
      tpm2: true
      threshold: 2
@bgilbert
Copy link
Contributor Author

bgilbert commented Dec 3, 2020

Updated!

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants