overlay/growfs: handle broken lsblk in el8 #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we've created a new filesystem anyway. This implicitly also works around the service racing against the `by-label/root` symlink not being up to date after reprovisioning (which `ignition-ostree-transposefs-restore.service` now intercepts and fixes).
Sometimes `lsblk` returns devices in the wrong order, so we can't rely on it to iterate over the devices in hierarchical order. Instead, use the `holders/` directory ourselves directly and use `--nodeps` when calling `lsblk`. See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4 See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607 See: coreos/coreos-installer#453
|
(And yes, we want to rewrite this into a compiled language eventually. At the very least so we can use |
travier
approved these changes
Mar 19, 2021
|
Tested the nvme and non nvme case. Both successfully grew to fill the disk. |
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Mar 19, 2021
I.e. coreos/fedora-coreos-config#900 (for https://bugzilla.redhat.com/show_bug.cgi?id=1934863) and coreos/fedora-coreos-config#903 (for https://bugzilla.redhat.com/show_bug.cgi?id=1940966). ``` Jonathan Lebon (8): overrides: pin to kernel-5.10.19-200.fc33 for rootless podman image.yaml: bump virtual disk images to 10G manifest: use `mkdir -p` for resolved.conf.d/ dir overlay: don't restamp rootfs UUID if reprovisioning overlay/growfs: handle broken lsblk in el8 tests/misc-ro: check for prjquota tests/root-reprovision: use `ok` and `fatal` helpers overlay: always use prjquota for XFS rootfs Luca BRUNO (2): fedora-coreos-base: add nm-cloud-setup, forward platform variables lockfile: refresh after manifest changes Sohan Kunkerkar (1): overrides: fast-track coreos-installer 0.8.0 ```
jlebon
added a commit
to jlebon/os
that referenced
this pull request
Mar 19, 2021
I.e. coreos/fedora-coreos-config#900 (for https://bugzilla.redhat.com/show_bug.cgi?id=1934863) and coreos/fedora-coreos-config#903 (for https://bugzilla.redhat.com/show_bug.cgi?id=1940966). ``` Jonathan Lebon (5): overlay: don't restamp rootfs UUID if reprovisioning overlay/growfs: handle broken lsblk in el8 tests/misc-ro: check for prjquota tests/root-reprovision: use `ok` and `fatal` helpers overlay: always use prjquota for XFS rootfs ```
miabbott
pushed a commit
to jlebon/os
that referenced
this pull request
Mar 22, 2021
I.e. coreos/fedora-coreos-config#900 (for https://bugzilla.redhat.com/show_bug.cgi?id=1934863) and coreos/fedora-coreos-config#903 (for https://bugzilla.redhat.com/show_bug.cgi?id=1940966). ``` Jonathan Lebon (5): overlay: don't restamp rootfs UUID if reprovisioning overlay/growfs: handle broken lsblk in el8 tests/misc-ro: check for prjquota tests/root-reprovision: use `ok` and `fatal` helpers overlay: always use prjquota for XFS rootfs ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes
lsblkreturns devices in the wrong order, so we can't relyon it to iterate over the devices in hierarchical order. Instead, use
the
holders/directory ourselves directly and use--nodepswhencalling
lsblk.See: https://bugzilla.redhat.com/show_bug.cgi?id=1934174#c4
See: https://bugzilla.redhat.com/show_bug.cgi?id=1940607
See: coreos/coreos-installer#453