Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

rcscheduler command does expose namespace parameter as flag #3

Open
colhom opened this issue Nov 23, 2015 · 2 comments
Open

rcscheduler command does expose namespace parameter as flag #3

colhom opened this issue Nov 23, 2015 · 2 comments

Comments

@colhom
Copy link
Contributor

colhom commented Nov 23, 2015

This needs to be configurable

@philips
Copy link

philips commented Nov 26, 2015

Could you dump in a small example into this bug on how you envision this might work so someone could hack on this if they wanted to?

@colhom
Copy link
Contributor Author

colhom commented Nov 26, 2015

cmd/rcscheduler/rcscheduler.go

Here's where the namespace parameter is passed to the routine. It's determined at compile time now.

    rcScheduler := routines.NewRoutine(
        client,
        time.Duration(pollInterval)*time.Second,
        time.Duration(podTTL)*time.Second,
        &routines.RCScheduler{
            Client:       client,
            Namespace:    "khealth",
            ReplicaCount: 3,
        },
    )

The Namespace: "khealth" part needs to use a string set via flag.StringVar.

It would be nice to do the same for ReplicaCount as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants