Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Remove redundant code between approver and signer components #12

Open
rithujohn191 opened this issue Feb 27, 2018 · 1 comment
Open

Remove redundant code between approver and signer components #12

rithujohn191 opened this issue Feb 27, 2018 · 1 comment

Comments

@rithujohn191
Copy link
Contributor

Currently there are a few common util methods that are used by both the signer and the approver, remove redundancy and re-use commone code.
@rithujohn191 rithujohn191 mentioned this issue Feb 27, 2018
Merged
@ericchiang
Copy link
Contributor

I'd also recommend making this an internal package so other projects can't import the utilities. Makes it easier to make breaking changes in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericchiang @rithujohn191