This repository has been archived by the owner on May 7, 2021. It is now read-only.
ore/upload: Add --size-gib and --size-inspect #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have only compile-tested this; let me know if the design and overall approach seems OK and if so I'll do some manual tests. |
|
/cc @bgilbert |
cgwalters
force-pushed
the
image-size-take-2
branch
from
f073d0f
to
b7da1e0
Compare
cgwalters
changed the title
We want to expand the disk size of Red Hat CoreOS; previously there was a hardcoded 8GiB size for Container Linux which (I believe entirely coincidentally) matched RHCOS. See coreos#948 and coreos#944
cgwalters
force-pushed
the
image-size-take-2
branch
from
b7da1e0
to
a831fba
Compare
|
Having a forked mantle for this is still a big pain. It's going to hold up other work like adding tests in kola. I still find myself doubting the path of keeping mantle git master working for both CL and {F,RH}COS. If we did a |
|
(Today the mantle fork implies a coreos-assembler fork which in turn is causing more pain around things like dealing with the firstboot rename) |
|
Obsoleted by #959. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to expand the disk size of Red Hat CoreOS; previously
there was a hardcoded 8GiB size for Container Linux which
(I believe entirely coincidentally) matched RHCOS.
See #948
and #944