This repository has been archived by the owner on May 7, 2021. It is now read-only.
ore/aws/upload: --disk-size-gib and --disk-size-inspect, revisited #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were uploading the full disk image (4.5 GiB for CL) but hardcoding an 8 GiB disk size in AMI metadata. This worked until RHCOS images became larger than 8 GiB. Continue defaulting `ore aws upload` and plume to an 8 GiB AMI disk, but allow overriding from the ore command line, and add an ore option to autodetect the size from a local image file. Co-authored-by: Colin Walters <walters@verbum.org>
|
LGTM! Tested and works here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were uploading the full disk image (4.5 GiB for CL) but hardcoding an 8 GiB disk size in AMI metadata. This worked until RHCOS images became larger than 8 GiB. Continue defaulting
ore aws uploadand plume to an 8 GiB AMI disk, but allow overriding from the ore command line, and add an ore option to autodetect the size from a local image file.Based on, and obsoletes, #954. Tested with a CL image and:
ore aws upload, autodetected fileore aws upload --disk-size-gib, autodetected fileore aws upload --disk-size-inspect, autodetected fileore aws upload --disk-size-inspect --fileore aws upload --disk-size-inspect --source-object(fails)ore aws upload --disk-size-inspect --source-snapshot(fails)bin/plume pre-release --platform aws -C usercc @cgwalters for review (GitHub isn't letting me request one from you directly)