Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Insert placeholder in place of removed environment variables #39

Closed
brianredbeard opened this issue Jul 19, 2016 · 1 comment
Closed

Comments

@brianredbeard
Copy link
Member

When removing the environment variables from Dockerfiles (docker.go#L61), it isn't clear that there were ever environment variables there to begin with. It would be good to potentially inject a single variable to be used as a comment (the JSON format doesn't allow comments) informing the user that the variables were removed.

Alternately, replacing the values with something to the effect of scrubbed by mayday would allow the user to see that the container was instantiated with the correct variable names even if they don't know the values.

Affects #32

@tschuy
Copy link
Contributor

tschuy commented Jul 20, 2016

I've pushed something to this effect in #32.

@tschuy tschuy closed this as completed Jul 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants