stage0: minor wording fixes #3351
Conversation
|
/cc @squeed |
| @@ -28,7 +28,7 @@ var ( | |||
| cmdAppStart = &cobra.Command{ | |||
| Use: "start UUID --app=NAME", | |||
| Short: "Start an app in a pod", | |||
| Long: `Start appz!`, | |||
| Long: "This allows starting an existing application inside a mutable pod", | |||
There was a problem hiding this comment.
I don't like this "allows" verbiage - it does start an app in a mutable pod, does it not?
There was a problem hiding this comment.
I tend to agree with you here. I changed the other two subcommands to get rid of the "allows" occurrences there too.
lucab
force-pushed
the
to-upstream/sandbox-fixes
branch
from
b062ae7
to
d80042b
Compare
| @@ -28,7 +28,7 @@ var ( | |||
| cmdAppStart = &cobra.Command{ | |||
| Use: "start UUID --app=NAME", | |||
| Short: "Start an app in a pod", | |||
| Long: `Start appz!`, | |||
| Long: "This starts an existing application inside a mutable pod", | |||
There was a problem hiding this comment.
how about "e.g. one that was previously added with rkt app add"
| @@ -32,7 +32,7 @@ var ( | |||
| cmdAppAdd = &cobra.Command{ | |||
| Use: "add UUID IMAGEID ...", | |||
| Short: "Add an app to a pod", | |||
| Long: `This allows addin an app that's present on the store to a running pod`, | |||
| Long: "This adds a locally stored application to a running mutable pod", | |||
There was a problem hiding this comment.
"locally stored application" is a bit confusing?
There was a problem hiding this comment.
It may be. Do you prefer original wording or do you have some better suggestion for this?
There was a problem hiding this comment.
"Adds an application available in the local image store to a running mutable pod"
lucab
force-pushed
the
to-upstream/sandbox-fixes
branch
from
d80042b
to
98fec70
Compare
|
Rephrased a little bit with @euank and @jonboulle wording. |
|
lgtm |
|
Semaphore failure is the known kvm stop flake. |
Minor rewording after CRI merge, cleaning up "appz" occurrences.