This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
kvm: fix for breaking change in Debian Sid GCC default options #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jjlakis and @lukasredynk for the very quick investigation and fix. Assigning to @s-urbaniak for the final review. |
|
I tested this with the 1.1.1 rkt-builder, and the build is working again, thanks a lot! |
s-urbaniak
reviewed
Nov 9, 2016
| AS = $(CROSS_COMPILE)as | ||
| LD = $(CROSS_COMPILE)ld | ||
| -CC = $(CROSS_COMPILE)gcc | ||
| +CC = $(CROSS_COMPILE)gcc -no-pie -fno-pic |
There was a problem hiding this comment.
As this has been discussed also in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841368#36 and other places I am fine with this change, as the kernel apparently doesn't support pic mode.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With change introduced to Debian Sid default gcc flags: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=841368 both lkvm and linux kernel wouldn't compile, here is fix for this.
Fixes #3343