Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rpm-ostree kargs in container builds #3738

Open
LorbusChris opened this issue Jun 8, 2022 · 3 comments
Open

Support rpm-ostree kargs in container builds #3738

LorbusChris opened this issue Jun 8, 2022 · 3 comments
Labels
container-native triaged This issue was triaged

Comments

@LorbusChris
Copy link
Collaborator

Host system details

$ rpm-ostree --version
rpm-ostree:
 Version: '2022.9'
 Git: 44031a71f444ec63ed292f8807b5bb04a0cf3329
 Features:
  - rust
  - compose
  - fedora-integration

Expected vs actual behavior

Running buildah build with the following Dockerfile:

FROM quay.io/coreos-assembler/fcos:testing-devel

RUN rpm-ostree kargs --replace mitigations=auto,nosmt=off && \
    rpm-ostree kargs --append intel_pstate=disable && \
    rpm-ostree cleanup -m && \
    ostree container commit

ENTRYPOINT ["/noentry"]

yields

STEP 1/3: FROM quay.io/coreos-assembler/fcos:testing-devel
STEP 2/3: RUN rpm-ostree kargs --replace mitigations=auto,nosmt=off &&     rpm-ostree kargs --append intel_pstate=disable &&     rpm-ostree cleanup -m &&     ostree container commit
error: This system was not booted via libostree.
Currently, most rpm-ostree commands only work on ostree-based host systems.

error building at STEP "RUN rpm-ostree kargs --replace mitigations=auto,nosmt=off &&     rpm-ostree kargs --append intel_pstate=disable &&     rpm-ostree cleanup -m &&     ostree container commit": error while running runtime: exit status 1

Expected:
Successful manipulation of the kernel arguments stored in the image

@jlebon
Copy link
Member

jlebon commented Jun 8, 2022

I think this will likely require distro-level integration to work. It might be better to move this to https://github.com/coreos/fedora-coreos-tracker, but we can leave it here for now.

@cgwalters
Copy link
Member

Yeah, I definitely want this too. I think it would be particularly powerful if we also had our cliwrap'd version of grubby also do the same thing.

@IverCoder
Copy link

What's the progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container-native triaged This issue was triaged
Projects
None yet
Development

No branches or pull requests

4 participants